[rocisa][stinkytofu] Move rocisa conversion glue out of stinkytofu#8765
[rocisa][stinkytofu] Move rocisa conversion glue out of stinkytofu#8765KKyang wants to merge 1 commit into
Conversation
The conversion sources (AllHwMappings, ToStinkyTofuUtils, *ArchInfo headers) are rocisa-side bindings — they include rocisa headers, reference rocisa types, and are compiled into _rocisa, not libstinkytofu. Moving them to rocisa/src/stinkytofu/ makes ownership explicit and removes the cross-repo source path hack from rocisa's CMakeLists. GenRocisaHwMapping.cpp stays in stinkytofu's tablegen (it needs gfxisa internals) but is marked for removal when rocisa is replaced by stinkytofu IR.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8765 +/- ##
========================================
Coverage 71.43% 71.43%
========================================
Files 2612 2612
Lines 407038 407038
Branches 60777 60777
========================================
Hits 290766 290766
Misses 94969 94969
Partials 21303 21303
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Alex-Vasile
left a comment
Alex-Vasile
left a comment
There was a problem hiding this comment.
Looks good other than a stale doc issue. Please fix before merging.
There was a problem hiding this comment.
Several docs still point contributors to the removed shared/stinkytofu/src/conversion/rocisa layout. After this move, the “add architecture” instructions would send new rocisa conversion headers
to a path that no longer exists. At minimum, update the adding-architecture checklist and related architecture/tablegen docs to the new projects/hipblaslt/tensilelite/rocisa/rocisa/src/stinkytofu
location. Examples: stinkytofu/docs/developer/adding-architecture.md:142, stinkytofu/
docs/developer/architecture.md:66, stinkytofu/tools/tablegen/README.md:181.
3 participants
Summary
AllHwMappings.cpp/.hpp,ToStinkyTofuUtils.cpp,RocisaArchInfo.hpp, andGfx1250RocisaArchInfo.hppfromshared/stinkytofu/src/conversion/rocisa/toprojects/hipblaslt/tensilelite/rocisa/rocisa/src/stinkytofu/init_stinkytofu) that compile into_rocisa— notlibstinkytofu. Moving them makes ownership explicit._stinkytofu_src_dir) from rocisa's CMakeLists; sources are now referenced locally.GenRocisaHwMapping.cppstays in stinkytofu's tablegen (requiresgfxisainternals) but is marked TODO for removal when rocisa is replaced by stinkytofu IR.Test plan
scikit-build-core) compiles cleanlyfind_package(stinkytofu)build compiles cleanly